Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#major); friend-tech; add friend-tech subgraph #2384

Merged
merged 14 commits into from
Nov 29, 2023
Merged

feat(#major); friend-tech; add friend-tech subgraph #2384

merged 14 commits into from
Nov 29, 2023

Conversation

dhruv-chauhan
Copy link
Collaborator

@dhruv-chauhan dhruv-chauhan commented Sep 26, 2023 •
edited
Loading

Description

  • Added friend-tech subgraph using non-standard schema.
  • Added configs for networks: base

Links

New Subgraph Checklist

  • Researched protocol / contracts
  • Modeled off this template using the latest versions
  • Updated title
  • Added subgraph(s) to deployment.json
  • Used standard subgraph libraries (if necessary/available)
  • General aggregate metrics can be similar to known sources like the protocol or defi llama (The detailed QA will be done by a protocol specialist)
  • Assigned the proper reviewers. If you are unsure, ask in our discord!
  • Followed docs, especially WALKTHROUGH.md

@dhruv-chauhan dhruv-chauhan marked this pull request as ready for review September 28, 2023 11:58
@dhruv-chauhan dhruv-chauhan linked an issue Sep 28, 2023 that may be closed by this pull request
Build friend.tech subgraph #2372
Closed
melotik
melotik reviewed Oct 5, 2023
View reviewed changes
deployment/deployment.json Outdated Show resolved Hide resolved
melotik
melotik previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm! Once the QA passes let's change to prod and merge :)

@melotik melotik dismissed their stale review October 13, 2023 21:24

Will re-review once we convert to generic schema

melotik
melotik approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! We do have a generic sdk, but I will let you decide if it is worth the effort to convert it (prolly not imo, since there are so many new fields, this is alr written, and some of the new fields rely on values used in the sdk)

subgraphs/friend-tech/abis/Shares.json Outdated Show resolved Hide resolved
melotik
melotik reviewed Nov 3, 2023
View reviewed changes
deployment/deployment.json Outdated Show resolved Hide resolved
@melotik
Copy link
Contributor

melotik commented Nov 8, 2023

https://thegraph.com/hosted-service/subgraph/messari/friend-tech-base

@dhruv-chauhan dhruv-chauhan merged commit c14b1c3 into messari:master Nov 29, 2023
4 checks passed
@dhruv-chauhan dhruv-chauhan deleted the friend-tech branch November 29, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melotik melotik melotik approved these changes

@bye43 bye43 Awaiting requested review from bye43

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build friend.tech subgraph
2 participants
@dhruv-chauhan @melotik